Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): make all permitted user profile fields available when using limited login #582

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

ranjit-akalilabs
Copy link
Contributor

Since Graph API cannot be used, this seems to be the only way to access additional user profile fields such as user's birthday, as per official documentation.

Fixes #525

Test Plan:

I granted all personalisation permissions to my app via the developer portal and specified them during login.
image

However, not all fields returned were populated even though the permission was granted.
image

So I created a test profile for e2e testing to ensure all mappings are working.
image

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks really good, thank you

@mikehardy mikehardy changed the title Adds additional user profile fields available only when using limited login on iOS feat(ios): make all permitted user profile fields available when using limited login Nov 26, 2024
@mikehardy
Copy link
Collaborator

Hey @ranjit-akalilabs 👋
if you run yarn lint:prettier --write and commit the result, the lint check will pass

@mikehardy mikehardy added needs more info waiting on original poster to provide details pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. labels Nov 26, 2024
@mikehardy mikehardy merged commit b297eb6 into thebergamo:master Nov 26, 2024
4 checks passed
@mikehardy mikehardy removed needs more info waiting on original poster to provide details pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. labels Nov 26, 2024
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
## [13.3.0](v13.2.0...v13.3.0) (2024-11-26)

### Features

* **ios:** make all permitted user profile fields available when using limited login ([#582](#582)) ([b297eb6](b297eb6))
Copy link

🎉 This PR is included in version 13.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS limited login does not return all possible fields
2 participants