This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Always start modes with initial settings #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge this for the moment. I just recognized that the reset is not good for the options that are persisted in the config :). Will fix this first and update the PR. |
In previous versions the board kept runtime information per mode when switching between modes. This could have odd effects, for example the "color wipe" mode could be invisible for some time when it was in the "fade out" phase when switching to the mode. This change now separates the mode member variables into two categories: Config: These are initialized with their default values at class level once and need to be overridden with the applyConfig() method. State: These are not allowed to be persisted with the config and may change at any time during animation. They need to be initialized in the initialize() method.
LarsMichelsen
force-pushed
the
clean-init-modes
branch
from
bc51b33 to
c8d20af
Compare
|
Just updated this PR. Feel free to try / merge. |
|
Looks good, but will need to merge with #36. I'll hold off for now. |
|
Decided to merge this, works great and i think it will be important to have for the library restructure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions the board kept runtime information per mode
when switching between modes. This could have odd effects, for
example the "color wipe" mode could be invisible for some time
when it was in the "fade out" phase when switching to the mode.