📦 Refactor to avoid using additional kernel exception listener

thecodingmachine · Jan 5, 2025 · 57abcaa · 57abcaa
1 parent 03af0fe
commit 57abcaa
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 57 deletions.
diff --git a/EventListener/ExceptionListener.php b/EventListener/ExceptionListener.php
diff --git a/src/Controller/GraphQLiteController.php b/src/Controller/GraphQLiteController.php
@@ -1,9 +1,15 @@
 <?php
 
-
 namespace TheCodingMachine\GraphQLite\Bundle\Controller;
 
-
+use GraphQL\Error\Error;
+use Laminas\Diactoros\ResponseFactory;
+use Laminas\Diactoros\ServerRequestFactory;
+use Laminas\Diactoros\StreamFactory;
+use Laminas\Diactoros\UploadedFileFactory;
+use Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFactory;
+use TheCodingMachine\GraphQLite\Http\HttpCodeDecider;
+use TheCodingMachine\GraphQLite\Http\HttpCodeDeciderInterface;
 use GraphQL\Executor\ExecutionResult;
 use GraphQL\Server\ServerConfig;
 use GraphQL\Server\StandardServer;
@@ -24,10 +30,12 @@
 use TheCodingMachine\GraphQLite\Bundle\Context\SymfonyGraphQLContext;
 use TheCodingMachine\GraphQLite\Http\HttpCodeDecider;
 use TheCodingMachine\GraphQLite\Http\HttpCodeDeciderInterface;
+use TheCodingMachine\GraphQLite\Bundle\Exceptions\JsonException;
+
+use function array_map;
 use function array_map;
 use function class_exists;
 use function json_decode;
-use TheCodingMachine\GraphQLite\Bundle\Exceptions\JsonException;
 
 /**
  * Listens to every single request and forward Graphql requests to Graphql Webonix standardServer.
@@ -88,19 +96,13 @@ public function handleRequest(Request $request): Response
                     flags: \JSON_THROW_ON_ERROR
                 );
             } catch (\JsonException $e) {
-                throw JsonException::create(
-                    reason: $e->getMessage(),
-                    code: Response::HTTP_UNSUPPORTED_MEDIA_TYPE,
-                    previous:$e
-                );
+                return $this->invalidJsonBodyResponse($e);
             }
 
             if (!is_array($parsedBody)) {
-                throw JsonException::create(
-                    reason: 'Expecting associative array from request, got ' . gettype($parsedBody),
-                    code: Response::HTTP_UNPROCESSABLE_ENTITY
-                );
+                return $this->invalidRequestBodyExpectedAssociativeResponse($parsedBody);
             }
+
             $psr7Request = $psr7Request->withParsedBody($parsedBody);
         }
 
@@ -139,4 +141,51 @@ private function handlePsr7Request(ServerRequestInterface $request, Request $sym
 
         throw new RuntimeException('Only SyncPromiseAdapter is supported');
     }
+
+    private function invalidJsonBodyResponse(\JsonException $e): JsonResponse
+    {
+        $jsonException = JsonException::create(
+            reason: $e->getMessage(),
+            code: Response::HTTP_UNSUPPORTED_MEDIA_TYPE,
+            previous: $e,
+        );
+        $result = new ExecutionResult(
+            null,
+            [
+                new Error(
+                    'Invalid JSON.',
+                    previous: $jsonException,
+                    extensions: $jsonException->getExtensions(),
+                ),
+            ]
+        );
+
+        return new JsonResponse(
+            $result->toArray($this->debug),
+            $this->httpCodeDecider->decideHttpStatusCode($result)
+        );
+    }
+
+    private function invalidRequestBodyExpectedAssociativeResponse(mixed $parsedBody): JsonResponse
+    {
+        $jsonException = JsonException::create(
+            reason: 'Expecting associative array from request, got ' . gettype($parsedBody),
+            code: Response::HTTP_UNPROCESSABLE_ENTITY,
+        );
+        $result = new ExecutionResult(
+            null,
+            [
+                new Error(
+                    'Invalid JSON.',
+                    previous: $jsonException,
+                    extensions: $jsonException->getExtensions(),
+                ),
+            ]
+        );
+
+        return new JsonResponse(
+            $result->toArray($this->debug),
+            $this->httpCodeDecider->decideHttpStatusCode($result)
+        );
+    }
 }
diff --git a/src/Resources/config/container/graphqlite.xml b/src/Resources/config/container/graphqlite.xml
@@ -87,10 +87,6 @@
             <tag name="routing.route_loader"/>
         </service>
 
-        <service id="TheCodingMachine\GraphQLite\Bundle\EventListener\ExceptionListener">
-            <tag name="kernel.event_listener" event="kernel.exception" method="onKernelException" />
-        </service>
-
         <service id="TheCodingMachine\GraphQLite\Bundle\Mappers\RequestParameterMiddleware">
             <tag name="graphql.parameter_middleware"/>
         </service>