feat: updated azure search #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aochmann
requested review from
imranhaidercogworks,
ja0b,
lkoruba,
mzajkowski and
trt
Test Run for PR #54 (107)Run Summary
Overall Result: ✔️ Pass
Result SetsCogworks.AzureSearch.UmbracoIoc.UnitTests.dll - 100%Full Results
Run MessagesInformationalWarningError |
src/Cogworks.AzureSearch/Mappers/AzureSearchParametersMapper.cs
Outdated
Show resolved
Hide resolved
src/Cogworks.AzureSearch/Mappers/AzureSearchParametersMapper.cs
Outdated
Show resolved
Hide resolved
src/Cogworks.AzureSearch/Mappers/AzureSearchParametersMapper.cs
Outdated
Show resolved
Hide resolved
src/Cogworks.AzureSearch/Mappers/AzureSearchParametersMapper.cs
Outdated
Show resolved
Hide resolved
src/Cogworks.AzureSearch/Services/AzureIndexOperationService.cs
Outdated
Show resolved
Hide resolved
src/Cogworks.AzureSearch/Services/AzureIndexOperationService.cs
Outdated
Show resolved
Hide resolved
src/Cogworks.AzureSearch/Services/AzureIndexOperationService.cs
Outdated
Show resolved
Hide resolved
| Size = azureSearchParameters.Take | ||
| }; | ||
|
|
||
| if (azureSearchParameters.Select.HasAny()) |
There was a problem hiding this comment.
Could we do these HasAny() and foreach statements as LINQ instead?
Or maybe it won't be as readable? 🤔
There was a problem hiding this comment.
I think it won't be readable. But we can try it 🤔 Can you serve some example how it would look like ?
Test Run for PR #54 (108)Run Summary
Overall Result: ✔️ Pass
Result SetsCogworks.AzureSearch.UmbracoIoc.UnitTests.dll - 100%Full Results
Run MessagesInformationalWarningError |
Test Run for PR #54 (109)Run Summary
Overall Result: ✔️ Pass
Result SetsCogworks.AzureSearch.UmbracoIoc.UnitTests.dll - 100%Full Results
Run MessagesInformationalWarningError |
refactor: names
Test Run for PR #54 (113)Run Summary
Overall Result: ✔️ Pass
Result SetsCogworks.AzureSearch.UmbracoIoc.UnitTests.dll - 100%Full Results
Run MessagesInformationalWarningError |
Test Run for PR #54 (114)Run Summary
Overall Result: ✔️ Pass
Result SetsCogworks.AzureSearch.UmbracoIoc.UnitTests.dll - 100%Full Results
Run MessagesInformationalWarningError |
Test Run for PR #54 (115)Run Summary
Overall Result: ✔️ Pass
Result SetsCogworks.AzureSearch.LightInject.UnitTests.dll - 100%Full Results
Run MessagesInformationalWarningError |
|
We need to add some method documentation about expected results and exceptions. We can do it on separate PR. Will create issue for it. |
mzajkowski
reviewed
May 13, 2021
| <file src="bin\Release\Cogworks.AzureSearch.LightInject.IocExtension.dll" target="lib/net48" /> | ||
| <file src="bin\Release\Cogworks.AzureSearch.Umbraco.IocExtension.dll" target="lib/net48" /> | ||
| </files> | ||
| <metadata> |
There was a problem hiding this comment.
Is this indenting forced by you or code style?
There was a problem hiding this comment.
this was a bug, it should be lib/net472
but spacing should be 2, but on my local it always convert to 4 - also if I change this setting. Will try again.
mzajkowski
approved these changes
May 13, 2021
Test Run for PR #54 (123)Run Summary
Overall Result: ✔️ Pass
Result SetsCogworks.AzureSearch.LightInject.UnitTests.dll - 100%Full Results
Run MessagesInformationalWarningError |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why it's submitted / why we need it:
Updated Azure Search to newer SDK.
In meantime done some refactor:
Another PR with future refactor will be applied (renaming, etc).
Checklist:
Needed this)developbranch or appropriatereleasebranchFixes: ### ISSUE_OR_TRELLO_LINK ###