saving this thing

thefinaljob · Aug 27, 2021 · 3cd0a65 · 3cd0a65
1 parent 0300733
commit 3cd0a65
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/packages/react-components/src/trace-explorer/trace-explorer-opened-traces-widget.tsx b/packages/react-components/src/trace-explorer/trace-explorer-opened-traces-widget.tsx
@@ -124,7 +124,6 @@ export class ReactOpenTracesWidget extends React.Component<ReactOpenTracesWidget
                         <AutoSizer>
                             {({ width }) =>
                                 <List
-                                    key={key}
                                     height={totalHeight}
                                     width={width}
                                     rowCount={this.state.openedExperiments.length}
@@ -159,6 +158,7 @@ export class ReactOpenTracesWidget extends React.Component<ReactOpenTracesWidget
             traces={this.state.openedExperiments[props.index].traces}
             experimentName={traceName}
             experimentUUID={traceUUID}
+            key={traceUUID}
             index={props.index}
             handleContextMenuEvent={this.handleContextMenuEvent}
             handleClickEvent={this.handleClickEvent}
@@ -248,11 +248,16 @@ export class ReactOpenTracesWidget extends React.Component<ReactOpenTracesWidget
     }
 
     protected handleTabNameUpdate(tabEditingOpen: string, index: number): void {
-        const exp = this.state.openedExperiments[index];
-        exp.name = tabEditingOpen;
-        const experimentOpenNew = this.state.openedExperiments;
-        experimentOpenNew[index] = exp;
-        this.setState({openedExperiments: experimentOpenNew});
+        this.setState(({openedExperiments}) => ({
+            openedExperiments: [
+                ...openedExperiments.slice(0,index),
+                {
+                    ...openedExperiments[index],
+                    name: tabEditingOpen,
+                },
+                ...openedExperiments.slice(index + 1)
+            ]
+        }));
     }
 
     protected handleShareButtonClick = (index: number): void => this.doHandleShareButtonClick(index);