Foreman expects LDAP server to follow RFC2307 #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for 0346883 is available at theforeman-foreman-documentation-preview-pr-3277.surge.sh The following output files are affected by this PR: |
aneta-petrova
added
Needs tech review
maximiliankolb
approved these changes
Sep 12, 2024
guides/common/modules/proc_configuring-project-to-use-ldap.adoc
Outdated
Show resolved
Hide resolved
maximiliankolb
added
style review done
ekohl
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Adding a prerequisite stating that when connecting to an LDAP server as an external authentication source, that LDAP server needs to be RFC2307-compliant.
In theforeman/ldap_fluff#78 some work started on supporting this, but for now we should document this limitation.
maximiliankolb
added
tech review done
Co-authored-by: Maximilian Kolb <[email protected]>
|
Thanks, Maximilian and Ewoud, for the review. I notified my team about this PR too and would like to give them space to review as well if they choose to. Let's keep this PR open until next week. |
maximiliankolb
approved these changes
Sep 13, 2024
aneta-petrova
added a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: Maximilian Kolb <[email protected]> (cherry picked from commit 4514b45)
aneta-petrova
added a commit
that referenced
this pull request
Sep 17, 2024
Co-authored-by: Maximilian Kolb <[email protected]> (cherry picked from commit 4514b45)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Adding a prerequisite stating that when connecting to an LDAP server as an external authentication source, that LDAP server needs to be RFC2307-compliant.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-25037 and https://bugzilla.redhat.com/show_bug.cgi?id=2127089
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I expect a conflict on 3.10 and lower but the change should go into those versions too.
Checklists
Please cherry-pick my commits into: