-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop GSS proxy privilege separation from direct AD integration proc (3.10) #3325
Conversation
The PR preview for 2cd4eeb is available at theforeman-foreman-documentation-preview-pr-3325.surge.sh The following output files are affected by this PR: |
This |
@asteflova Please use |
Sorry @maximiliankolb poor choice of words in my comment above. This PR doesn't cherry-pick the commit from 3.11 and above because of all the other changes that have been happening in external authentication since 3.11. We are essentially dealing with different documentation sections. What I should have wrote is that I updated the relevant parts of 3.10 docs to match the corresponding parts of 3.11and above. The goal was to remove references to GSS proxy on 3.10 and lower. Would you prefer me to do a standard cherry-pick? I could do that but then I'd have to apply another commit that would revert some of those changes back to the original state so that the updated sections are consistent with the rest of 3.10 (mostly, this would mean changes to introductions and assembly includes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just being lazy and trying to review as little as possible. A cherry-pick "by hand" is also OK here; maybe you can edit your commit message before merging and reference the PR/original commit in some way. |
Nah, I was the lazy one and didn't want to deal with all the conflicts and manual reverts. Thanks for the ack.
Will do, thanks for the tip. |
What changes are you introducing?
Applying the changes implemented in #3149 to versions 3.10 and earlier.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Explained in #3149
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Checklists
Please cherry-pick my commits into:
* [ ] Foreman 3.12/Katello 4.14 (Satellite 6.16)* [ ] Foreman 3.11/Katello 4.13