Remove references to the Override checkbox for filters #3548
Conversation
aneta-petrova
added
Needs tech review
|
The PR preview for 0e8616e is available at theforeman-foreman-documentation-preview-pr-3548.surge.sh The following output files are affected by this PR: |
| The *Unlimited* checkbox is selected by default, which means that the permission is applied on all resources of the selected type. | ||
| When you disable the *Unlimited* checkbox, the *Search* field activates. | ||
| . For certain *Resource type* options, the *Unlimited* checkbox is available. | ||
| If *Unlimited* is selected, the permission is applied on all resources of the selected type. |
There was a problem hiding this comment.
We might want to add that unlimited will be disabled if the role parent has a loc/org selected, alert in foreman says: "Info alert:The filter is scoped to the selected organizations and locations, therefore can't be unlimited"
There was a problem hiding this comment.
I'm inclined to say that we don't need to go into this kind of detail here. I left a comment on the code PR with a minor suggestion to change the wording of the alert. I'd say that if users will know what's happening from looking at the web UI form, then that's great and there is no need for additional words in the docs.
|
Thanks for the reviews, that covers tech review. |
aneta-petrova
added
tech review done
aneta-petrova
added
style review done
What changes are you introducing?
I'm removing references to the ability to override organizations and locations on the filter level.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
The option to override orgs and locs on the filter level is being removed in theforeman/foreman#10370
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: