Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Managing Foreman with Ansible" guide #3592

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove "Managing Foreman with Ansible" guide #3592

wants to merge 3 commits into from

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Jan 17, 2025 •
edited
Loading

What changes are you introducing?

Show Administering Foreman with Ansible guide for all builds

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Part of #396

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Alternative: we remove this guide because it is already part of https://docs.theforeman.org/nightly/Administering_Project/index-katello.html#managing-foreman-with-ansible

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

no cherry-picks

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

The PR preview for b3032c7 is available at theforeman-foreman-documentation-preview-pr-3592.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@maximiliankolb maximiliankolb mentioned this pull request Jan 17, 2025
Merged
9 tasks
ekohl
ekohl reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I'd argue it's already shown for all flavors but this declares that we feel comfortable that it's ready for consumption.

@maximiliankolb
Copy link
Contributor Author

Technically I'd argue it's already shown for all flavors but this declares that we feel comfortable that it's ready for consumption.

Yes. The more I look at it, the more I think we don't need this tiny guide because it's already in https://docs.theforeman.org/nightly/Administering_Project/index-katello.html#Managing_Project_with_Ansible_Collections_admin

@Lennonka
Copy link
Contributor

+1 for removing it altogether

@aneta-petrova
Copy link
Member

+1 for removing it. (It seems pretty feature-based anyway, doesn't it?)

@maximiliankolb maximiliankolb force-pushed the show_managing_foreman_with_ansible_for_all_flavours branch from 875031d to b3032c7 Compare January 21, 2025 15:07
@maximiliankolb maximiliankolb changed the title Show managing Foreman with Ansible for all flavours Remove "Managing Foreman with Ansible" guide Jan 21, 2025
@maximiliankolb
Copy link
Contributor Author

TODO: after squashing and merging this PR, I have to open a PR against gh-pages to remove the built guide so that we do not end up with an outdated guide on docs.theforeman.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@aneta-petrova aneta-petrova aneta-petrova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximiliankolb @Lennonka @aneta-petrova @ekohl