Add invalidating registration tokens #3595
Conversation
|
The PR preview for b339ba8 is available at theforeman-foreman-documentation-preview-pr-3595.surge.sh The following output files are affected by this PR: |
Lennonka
force-pushed
the
add-invalidating-reg-tokens
branch
from
f6abc2f to
97ccbee
Compare
Lennonka
added
the
Waiting for code
|
@asteflova Can you please review this for placement and structure for now? |
| [options="nowrap" subs="+quotes,attributes,verbatim"] | ||
| ---- | ||
| $ curl | ||
| ---- |
There was a problem hiding this comment.
Is there an Ansible module too?
| ---- | |
| ---- | |
| .Ansible procedure |
There was a problem hiding this comment.
I don't think there will be. @girijaasoni Can you please confirm?
You're adding the procedures to a chapter named Managing users and roles. Except this is not quite about managing users, is it? If I look at the chapter introduction, it talks about creating accounts and managing their permissions. I don't think registration tokens are part of that. Invalidating registration tokens is not something you're likely to want to do when managing user accounts and permissions. It's something you're more likely to want to do when/after registering hosts. So perhaps add this to Managing Hosts? Around the place where you now only add an external link? |
| To use the CLI instead of the {ProjectWebUI}, see the xref:cli-invalidating-jwts-of-all-usersvvv[]. | ||
| To use the API, see the xref:api-invalidating-jwts-of-all-users[]. | ||
|
|
||
| .Prerequisites |
There was a problem hiding this comment.
we don't need view_users permissions for api or cli
There was a problem hiding this comment.
That depends on how we write the procedure. In some cases it can be beneficial to list users to find their IDs before they run the main command. In such case, they would need the view_users permission, wouldn't they?
I'll revisit this once I have the commands ready.
| + | ||
| [options="nowrap" subs="+quotes,attributes,verbatim"] | ||
| ---- | ||
| $ hammer registration-tokens invalidate ??? |
There was a problem hiding this comment.
@girijaasoni What is the command to invalidate tokens for all users?
What changes are you introducing?
Adding 3 procedures for invalidation of the registration JSON Web Tokens (JWTs):
All three user stories will be available in the UI, CLI, and API.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Redmine: 37936, 38138, ... (TBD)
RH Jira: SAT-27385 (private)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A