Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concept for Package and Image Mode Hosts #3611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bangelic
Copy link
Contributor

What changes are you introducing?

Adding a concept for understanding package
mode and image mode hosts.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

This is in reference to https://issues.redhat.com/browse/SAT-28164.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@bangelic
Copy link
Contributor Author

@ianballou This is the concept for Package and Image Mode hosts. The procedure for https://issues.redhat.com/browse/SAT-28185 will be in another PR.

@ianballou ianballou changed the title Add concept for Package and Imahe Mode Hosts Add concept for Package and Image Mode Hosts Jan 24, 2025
Copy link
Contributor

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments only here!


* *Booted Image & Digest*: Indicates the container image the host is currently using.
* *Staged Image & Digest*: Indicates the container image the host uses after the next reboot.
* *Available Image & Digest*: Represents the container image cached by running `Bootc upgrade --check`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* *Available Image & Digest*: Represents the container image cached by running `Bootc upgrade --check`.
* *Available Image & Digest*: Represents the container image cached by running `bootc upgrade --check`.

bootc should generally be lowercase -- it's only in the remote execution category that it's uppercase to be consistent with other category names.

* *Rollback Image & Digest*: Represents the container image the host reverts to after the next reboot if `Bootc rollback` is applied.

.All host listing page updates
* *New Column for Host Types*: The host listing page includes a column with icons that indicate the host type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a note should be included to remind users that the "Manage columns" feature can be used to add or remove the image mode column.

* *Rollback Image & Digest*: Represents the container image the host reverts to after the next reboot if `Bootc rollback` is applied.

.All host listing page updates
* *New Column for Host Types*: The host listing page includes a column with icons that indicate the host type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is only on the new hosts overview page, which is not the default yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants