Fixes #32885: Remove puppet from foreman::user_groups if present

The change theforeman/puppet-foreman#938
introduced dynamically determining if the puppet group needed to
be added to the foreman user. This no longer needs to be set
explicitly on the foreman::user_groups parameter thus the migration
cleans it up if present.

config/foreman.migrations/20210625142707_dynamic_puppet-in-foreman-groups.rb

@@ -0,0 +1,5 @@
+if answers['foreman'].is_a?(Hash)
+  if answers['foreman']['user_groups'] && answers['foreman']['user_groups'].include?('puppet')
+    answers['foreman']['user_groups'].delete('puppet')
+  end
+end

config/katello-answers.yaml

@@ -23,7 +23,6 @@ foreman:
   server_ssl_chain: /etc/pki/katello/certs/katello-server-ca.crt
   server_ssl_crl: ""
   server_ssl_key: /etc/pki/katello/private/katello-apache.key
-  user_groups: []
   websockets_ssl_cert: /etc/pki/katello/certs/katello-apache.crt
   websockets_ssl_key: /etc/pki/katello/private/katello-apache.key
 foreman::cli: true

config/katello.migrations/190314163941-remove-foreman-user-groups.rb

@@ -1,5 +1,3 @@
-if answers['foreman'].is_a?(Hash)
+if answers['foreman'].is_a?(Hash) && answers['foreman'].key?('user_groups')
   answers['foreman']['user_groups'] = []
-elsif answers['foreman']
-  answers['foreman'] = { 'user_groups' => [] }
 end

config/katello.migrations/210625142712-dynamic-puppet-in-foreman-groups.rb

@@ -0,0 +1,5 @@
+if answers['foreman'].is_a?(Hash)
+  if answers['foreman']['user_groups'] && answers['foreman']['user_groups'].include?('puppet')
+    answers['foreman']['user_groups'].delete('puppet')
+  end
+end

spec/fixtures/cleanup-foreman-user-groups/foreman-answers-after.yaml

@@ -0,0 +1,2 @@
+foreman:
+  user_groups: []

spec/fixtures/cleanup-foreman-user-groups/foreman-answers-before.yaml

@@ -0,0 +1,2 @@
+foreman:
+  user_groups: ['puppet']

spec/fixtures/cleanup-foreman-user-groups/katello-answers-after.yaml

@@ -0,0 +1,2 @@
+foreman:
+  user_groups: []

spec/fixtures/cleanup-foreman-user-groups/katello-answers-before.yaml

@@ -0,0 +1,2 @@
+foreman:
+  user_groups: ['puppet']

spec/migration_spec.rb

@@ -122,4 +122,24 @@
       end
     end
   end
+
+  %w[foreman katello].each do |scenario_name|
+    context "foreman drop puppet from user_groups" do
+      let(:answers_after) { load_fixture_yaml('cleanup-foreman-user-groups', "#{scenario_name}-answers-after.yaml") }
+      let(:scenario) do
+        {
+          :answers    => load_fixture_yaml('cleanup-foreman-user-groups', "#{scenario_name}-answers-before.yaml"),
+          :config     => load_config_yaml("#{scenario_name}.yaml"),
+          :migrations => config_path("#{scenario_name}.migrations"),
+        }
+      end
+
+      let(:migrator) { Kafo::Migrations.new(scenario[:migrations]).run(scenario[:config], scenario[:answers]) }
+
+      it 'changes scenario answers' do
+        _, after = migrator
+        expect(after).to include answers_after
+      end
+    end
+  end
 end