rubocop --auto-correct #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no idea why the current CI didn't flag those rubocop offenses, but #866 did, so here we are. |
ekohl
requested changes
Jan 22, 2024
| @@ -55,8 +55,8 @@ namespace :rh_cloud_inventory do | |||
|
|
|||
| desc "Synchronize Hosts inventory" | |||
| task sync: [:environment, 'dynflow:client'] do | |||
| if ! ENV['organization_id'].nil? | |||
| organizations = [ Organization.where(:id => ENV['organization_id']).first ] | |||
| if !ENV['organization_id'].nil? | |||
There was a problem hiding this comment.
Funny how the generate_upload is close, but not really the same in various subtle ways.
There was a problem hiding this comment.
We definitely can refactor both of them into using a helper method that will receive the action as lambda. Something along the lines of
with_organization_scope do |organization|
ForemanTasks.async_task(InventorySync::Async::InventoryFullSync, organization)
endIndeed it would be much prettier.
ekohl
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.