Fix installation of non-develop katello-devel box #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 29, 2023
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
dc5ef42
to
72edf9e
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
72edf9e
to
3b1a619
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
3b1a619
to
b375a39
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
b375a39
to
6f0f931
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
6f0f931
to
7fd8004
Compare
requires theforeman/puppet-katello_devel@e276ccb Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
7fd8004
to
543e287
Compare
m-bucher
commented
Jul 29, 2024
Comment on lines
21
to
22
| - "--katello-devel-extra-plugins theforeman/foreman_rh_cloud" | ||
| - "--katello-devel-extra-plugins theforeman/foreman_virt_who_configure" |
There was a problem hiding this comment.
Do we really always need this? This breaks the installation of a non-nightly version, because it always takes the latest version.
If we want to always install this (without making it optional), this would also need a possibility to configure the specific SCM-version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example probably does not work, since the mentioned fix to puppet-katello_devel is probably not available in the yum-repositories.
Requires theforeman/puppet-katello_devel@e276ccb