use ansible_default_ipv4 if possible when writing /etc/hosts #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Sep 4, 2024
| @@ -3,7 +3,7 @@ | |||
| lineinfile: | |||
| dest: /etc/hosts | |||
| regexp: ".*{{ item.replace('.', '-') }}$" | |||
| line: "{{ hostvars[item].ansible_host }} {{ item.replace('.', '-') }}.{{ etc_hosts_domain }} {{ item.replace('.', '-') }}" | |||
| line: "{{ ansible_default_ipv4['address'] | default(hostvars[item].ansible_host) }} {{ item.replace('.', '-') }}.{{ etc_hosts_domain }} {{ item.replace('.', '-') }}" | |||
There was a problem hiding this comment.
ansible_host is 127.0.0.1 when using VirtualBox, which confuses our installer (rightfully)
There was a problem hiding this comment.
I have tested, so the box is not spinning up with just this changes, but I tried to include the changes we tried to make earlier that is:
Adding 'compatibility_mode' => '2.0' in this file vagrant/lib/forklift/box_factory.rb#L111 and ansible_provisioner.compatibility_mode = '2.0' in vagrant/lib/forklift/box_distribution.rb#L193
This is doing our work but I still see this message:
Vagrant gathered an unknown Ansible version:
and falls back on the compatibility mode '1.8'.
Alternatively, the compatibility mode can be specified in your Vagrantfile:
https://www.vagrantup.com/docs/provisioning/ansible_common.html#compatibility_mode
There was a problem hiding this comment.
Yeah, the one to box distributor is needed, the other should not (I pushed it in here, just to be sure)
There was a problem hiding this comment.
It worked at first but I tried to up it again and seeing the same thing:
TASK [foreman_installer : Run installer] ***************************************
fatal: [centos9-stream-foreman-nightly]: FAILED! => changed=true
cmd: |-
foreman-installer -v --no-colors --scenario foreman --foreman-initial-admin-password changeme
delta: '0:00:02.888077'
end: '2024-09-10 18:18:49.890471'
msg: non-zero return code
rc: 20
start: '2024-09-10 18:18:47.002394'
stderr: Reverse DNS failed. Looking up 127.0.0.1 gave localhost, expected to match centos9-stream-foreman-nightly.akumari.example.com
stderr_lines: <omitted>
stdout: |-
2024-09-10 18:18:47 [NOTICE] [root] Loading installer configuration. This will take some time.
2024-09-10 18:18:49 [NOTICE] [root] Running installer with log based terminal output at level NOTICE.
2024-09-10 18:18:49 [NOTICE] [root] Use -l to set the terminal output log level to ERROR, WARN, NOTICE, INFO, or DEBUG. See --full-help for definitions.
Your system does not meet configuration criteria
stdout_lines: <omitted>
PLAY RECAP *********************************************************************
centos9-stream-foreman-nightly : ok=20 changed=1 unreachable=0 failed=1 skipped=19 rescued=0 ignored=0
Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.
In some setups it miss-detects the Ansible version and uses 1.8 compatiblity mode, which doesn't work properly with modern Ansible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.