Improve documentation #1863
Merged
Improve documentation #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- formatting - make some formatting compatible with mkdocs - broken links - implement learnings and add new content
ianballou
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Thanks for the improvements here, I speed-read the changes and things seem to look consistent, with updates focusing on formatting + modernizing versions and links (thanks especially for the new vagrant/hashicorp links!)
Since this is a widespread Forklift docs change we'll probably want an ack from @evgeni or @ekohl , but I haven't found anything off yet.
ianballou
reviewed
Oct 22, 2024
ianballou
reviewed
Oct 22, 2024
ianballou
reviewed
Oct 29, 2024
|
cc @Thorben-D |
ianballou
approved these changes
Oct 31, 2024
ekohl
approved these changes
Nov 1, 2024
|
Thanks @lumarel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
After the last code PR I thought it's time to take a day and try to improve the Forklift documentation 🙂
And this is the result from it.
This includes:
I have this changed version running here, if this makes checking it easier: https://gh.clmdn.eu/forklift/
If there is anything that needs further work I sure can do some more fixes!
Cheers, lumarel