Add hammer-cli-foreman-rh-cloud package #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShimShtein
force-pushed
the
hammer-cli-foreman-rh-cloud
branch
from
7abb94c
to
b086d7a
Compare
ShimShtein
force-pushed
the
hammer-cli-foreman-rh-cloud
branch
from
b086d7a
to
a013876
Compare
ShimShtein
force-pushed
the
hammer-cli-foreman-rh-cloud
branch
from
a013876
to
85ee868
Compare
ekohl
requested changes
Nov 22, 2023
ShimShtein
force-pushed
the
hammer-cli-foreman-rh-cloud
branch
from
85ee868
to
2a526a1
Compare
|
@ekohl Refactored the acceptance tests to incorporate the plugin the same way Katello does. |
ekohl
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Thanks! https://github.com/theforeman/foreman-plugin-overview/blob/014863c694f1d1642ed8751fa193a9c3a7a1b04a/config.yaml#L394 also needs an update after this, though perhaps only after we add it to foreman-installer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.