Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset all possible dash/underscore combinations of REMOTE_USER #1182

Merged
merged 1 commit into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. Unset all possible dash/underscore combinations of REMOTE_USER

    While the backend will always see underscores, as dashes are not
    permitted in environment variables that are used to pass these along,
    the frontend should always filter all possible notations, as otherwise
    an attacker could set the "REMOTE-USER" header which gets passed as
    "REMOTE_USER" unfiltered.
    
    Do the same for REMOTE_USER_* to avoid sneaking in groups that the
    user does not belong to and other user preferences.
    This however is only a theoretical attack vector once you can't
    spoof the REMOTE_USER variable anymore.
    
    (cherry picked from commit 80f1229)
    evgeni committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5f988fa View commit details
    Browse the repository at this point in the history