Fixes #37761 - use ProxyPass and upgrade=websocket where possible

[evgeni]

RewriteRules need special handling of some characters (esp "?"), which
differs based on Apache version. Instead of going down that way, we can
switch to using ProxyPass as proxying is the only thing we really need
here, at least for HTTP.

For WebSockets, we need to allow protocol upgrades, which modern
(2.4.47+) Apache can do itself via "ProxyPass … upgrade=websocket".
For older Apache (esp on EL8 and Ubuntu 20.04), we keep the RewriteRules
in place. To be removed when we drop support for those targets.

Co-Authored-By: Adam Ruzicka <[email protected]>

[evgeni]

Should this be undef instead?

[ehelms]

I tried testing this, but I think it's user error,. I just run into "Sorry" when I try to look at the web console.

[evgeni]

can you post a screenshot with the browser console open to the network tab (and after a reload, as otherwise the tab is empty)

[ehelms]

can you post a screenshot with the browser console open to the network tab (and after a reload, as otherwise the tab is empty)

[evgeni]

Eh, you have no cockpit on the target machine, or no ssh set up

[ehelms]

Eh, you have no cockpit on the target machine, or no ssh set up

I said user error. Cockpit is definitely set up. Let me double check SSH. Also, this error output sucks.

[evgeni]

foreman-installer --enable-foreman-plugin-remote-execution --enable-foreman-plugin-remote-execution-cockpit --enable-foreman-proxy-plugin-remote-execution-script --foreman-proxy-plugin-remote-execution-script-cockpit-integration true --foreman-proxy-plugin-remote-execution-script-install-key true

this should make cockpit work against the foreman box

and yes, please complain to cockpit-ws, we do not own that

[ehelms]

This works for me, thanks @evgeni !

[evgeni]

updated commit message etc.