POC: Require user to define server and client certificates #951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title here is perhaps a bit misleading, the goal of this draft POC is to allow design discussion about how we might design the following question:
How do we remove Puppet as the default certificates in the module but allow users to easily define the use of the Puppet certificates for use with puppet-foreman?
Today these paths are hard-coded, but also (as I understand it) exist in a more authoritative location within
puppet::server
: https://github.com/theforeman/puppet-puppet/blob/master/manifests/server.pp#L453-L463 Thus we ought to be able to provide a way (e.g wrapper/profile module? heira?) to use those paths as inputs to these Foreman parameters without hard coding.This is a similar problem for how Katello's certificate setup currently works. Today the paths Katello uses for certificates to Foreman are hard coded in the installer's answer file (https://github.com/theforeman/foreman-installer/blob/develop/config/katello-answers.yaml#L14-L28) but are all available in variables. For example, https://github.com/theforeman/puppet-certs/blob/master/manifests/apache.pp#L24-L26