Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Require user to define server and client certificates #951

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented May 11, 2021

The title here is perhaps a bit misleading, the goal of this draft POC is to allow design discussion about how we might design the following question:

How do we remove Puppet as the default certificates in the module but allow users to easily define the use of the Puppet certificates for use with puppet-foreman?

Today these paths are hard-coded, but also (as I understand it) exist in a more authoritative location within puppet::server: https://github.com/theforeman/puppet-puppet/blob/master/manifests/server.pp#L453-L463 Thus we ought to be able to provide a way (e.g wrapper/profile module? heira?) to use those paths as inputs to these Foreman parameters without hard coding.

This is a similar problem for how Katello's certificate setup currently works. Today the paths Katello uses for certificates to Foreman are hard coded in the installer's answer file (https://github.com/theforeman/foreman-installer/blob/develop/config/katello-answers.yaml#L14-L28) but are all available in variables. For example, https://github.com/theforeman/puppet-certs/blob/master/manifests/apache.pp#L24-L26

@ehelms
Copy link
Member Author

ehelms commented Jul 15, 2021

@ekohl I recall you once had some thoughts on how we could both support enforcing a user define these and perform some slightly automatic detection for the standard Puppet certificates use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants