Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dhcp_includes parameter #520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add dhcp_includes parameter #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,8 @@
#
# $dhcp_load_balance:: Cutoff after which load balancing is disabled
#
# $dhcp_includes:: Array of additional configuration files to be included into DHCP server configuration
#
# $dhcp_manage_acls:: Whether to manage DHCP directory ACLs. This allows the Foreman Proxy user to access even if the directory mode is 0750.
#
# $httpboot:: Enable HTTPBoot feature
Expand Down Expand Up @@ -427,6 +429,7 @@
Optional[Integer[0]] $dhcp_mclt = $::foreman_proxy::params::dhcp_mclt,
Optional[Integer[0, 255]] $dhcp_load_split = $::foreman_proxy::params::dhcp_load_split,
Optional[Integer[0]] $dhcp_load_balance = $::foreman_proxy::params::dhcp_load_balance,
Variant[Array[String], Optional[String]] $dhcp_includes = $::foreman_proxy::params::dhcp_includes,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these absolute paths or relative? I'd also limit it to just Array[String] and default it to []

Boolean $dhcp_manage_acls = $::foreman_proxy::params::dhcp_manage_acls,
Boolean $dns = $::foreman_proxy::params::dns,
Foreman_proxy::ListenOn $dns_listen_on = $::foreman_proxy::params::dns_listen_on,
Expand Down
1 change: 1 addition & 0 deletions manifests/params.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@
$dhcp_pxefilename = 'pxelinux.0'
$dhcp_network = undef
$dhcp_netmask = undef
$dhcp_includes = undef
# This will use the IP of the interface in $dhcp_interface, override
# if you need to. You can make this a comma-separated string too - it
# will be split into an array
Expand Down
1 change: 1 addition & 0 deletions manifests/proxydhcp.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
pxefilename => $foreman_proxy::dhcp_pxefilename,
omapi_name => $foreman_proxy::dhcp_key_name,
omapi_key => $foreman_proxy::dhcp_key_secret,
includes => $foreman_proxy::dhcp_includes,
}

::dhcp::pool{ $::domain:
Expand Down