Fixes #28961: Drop crane configuration from katello.yaml if using Pulp 3 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlsherrill Thoughts on this cleanup? We could also wait till 2.1 Foreman release to drop Crane, the external proxy situation complicates things since we are planning for it to be a Pulp 2 only deployment for a couple releases. |
ekohl
reviewed
Mar 11, 2020
| @@ -33,7 +33,9 @@ | |||
| :url: <%= @qpid_url %> | |||
| :subscriptions_queue_address: <%= @candlepin_event_queue %> | |||
|
|
|||
| <%- if @use_pulp_2_for_docker -%> | |||
There was a problem hiding this comment.
Should this be a line higher so you don't have an empty line at the end of the file?
|
Closing in favor of #356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.