Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gha-puppet again #310

Closed
wants to merge 4 commits into from
Closed

Use gha-puppet again #310

wants to merge 4 commits into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 10, 2023

This is to test out some new workflows where we again rely on the common workflows but while also adding the option to test multiple versions.

Right now it's unknown if this concept works.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ekohl
Copy link
Member Author

ekohl commented Oct 10, 2023

For complete context, there are now PRs up: voxpupuli/puppet_metadata#108 & voxpupuli/gha-puppet#42

@ekohl
Copy link
Member Author

ekohl commented Oct 10, 2023

Note to self: also support beaker_facter in .sync.yml so the file can be managed again.

@ekohl
Copy link
Member Author

ekohl commented Oct 11, 2023

Something is different with curl: curl: unknown --write-out variable: 'stderr.

When I run it manually on EL8:

# curl --silent --write-out '%{stderr}Response-Code: %{response_code}\n' https://ekohl.nl
<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx</center>
</body>
</html>
curl: unknown --write-out variable: 'stderr'
Response-Code: 301
# curl --silent --write-out '%{stderr}Response-Code: %{response_code}\n' https://ekohl.nl > /dev/null 
curl: unknown --write-out variable: 'stderr'
# curl --silent --write-out '%{stderr}Response-Code: %{response_code}\n' https://ekohl.nl 2> /dev/null 
<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx</center>
</body>
</html>
Response-Code: 301

So now I wonder how this ever worked. #311 is passing, but now I can't explain why.

Edit: the only thing I can imagine is that the previous helpers somehow mixed stdout and stderr together where now it's split.

@ekohl
Copy link
Member Author

ekohl commented Oct 11, 2023

Integrated in #309 now that all the bits are in.

@ekohl ekohl closed this Oct 11, 2023
@ekohl ekohl deleted the use-common-ci branch October 11, 2023 13:22
@ekohl
Copy link
Member Author

ekohl commented Oct 12, 2023

Following up: beaker-puppet hacked $PATH to include /opt/puppetlabs/puppet/bin so it used /opt/puppetlabs/puppet/bin/curl instead of /usr/bin/curl. beaker_puppet_helpers doesn't do that (because on a real system it's not in $PATH either.

@evgeni
Copy link
Member

evgeni commented Oct 12, 2023

Great detective work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants