Fixes #37062 - Rename pulpcore::telemetry to pulpcore::analytics #326
Conversation
Pulp changed the setting name to ANALYTICS. The original name TELEMETRY is deprecated and could be removed in the future.
|
Which Pulpcore release is the first to support the new name? 3.39? |
It was first introduced as TELEMETRY in 3.21 and renamed to ANALYTICS already in 3.22 |
|
Splendid, then it is a breaking change because we change params, but it doesn't influence the supported Pulpcore versions. |
A separate test is necessary for the default, because we don't omit the setting but rather comment it for discoverability. But we don't really need to test if any behaviors change by including a commented line (the file already includes many comments) so a unit test should suffice for that case.
|
Re-running the one test that failed, as the failure appeared transient. |
So we accidentally sent telemetry in 3.22, while we promised we didn't. That's not good. |
It was deprecated and a new naming scheme introduced alongside it. The TELEMETRY setting exists still in the main branch (https://github.com/pulp/pulpcore/blob/main/pulpcore/app/util.py#L320-L322). |
Pulp changed the setting name to ANALYTICS. The original name TELEMETRY is deprecated and could be removed in the future. Using pulp's preferred name will also remove the deprecation warning that appears in logs.