Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub metadata gem to better link source path #723

Closed
wants to merge 1 commit into from

Conversation

domcleal
Copy link
Contributor

No description provided.

@@ -14,7 +14,8 @@
</section>
<div class="footer">
<div class="container">
<p>This web site is licensed under a <a rel="license" href="http://creativecommons.org/licenses/by-sa/3.0/deed.en_GB">Creative Commons Attribution-ShareAlike 3.0 Unported License</a>. Source available: <a xmlns:dct="http://purl.org/dc/terms/" href="https://github.com/theforeman/theforeman.org" rel="dct:source">github/theforeman/theforeman.org</a></p>
<p>Edit and improve <a href="{{ site.github.repository_url }}/edit/gh-pages/{{ page.path }}">this page on GitHub</a>. All sources available: <a xmlns:dct="http://purl.org/dc/terms/" href="{{ site.github.repository_url }}" rel="dct:source">github/{{ site.repository }}</a></p>
Copy link
Member

@stbenjam stbenjam Oct 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat, but would it be better in a more prominent place? I don't think many people would notice this and it might encourage more contributions to pages like the manual if it were more visible.

Maybe something like [ Edit ] right aligned under the header?

@domcleal
Copy link
Contributor Author

I'm closing this as the gem is causing timeouts when building the site locally, since one of the APIs it accesses requires authentication (not a requirement I want to put on the build).

@domcleal domcleal closed this Oct 25, 2016
@stbenjam
Copy link
Member

The edit link is a cool idea, and it doesn't seem like the gem was adding much, why not just add repository_url to _config.yml?

@domcleal
Copy link
Contributor Author

I wasn't able to add an edit link to the top of the page as requested. I am however working on #423 to add edit links to the manual.

@stbenjam
Copy link
Member

stbenjam commented Oct 25, 2016

Oh right, that's a better idea anyway, editing the manual markdown isn't really helpful anyway since it's just a bunch of includes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants