Revived submitBatch #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavchellani
force-pushed
the
patch34
branch
from
38964e8
to
614c022
Compare
vaibhavchellani
force-pushed
the
patch34
branch
from
614c022
to
6765dd6
Compare
ChihChengLiang
approved these changes
Nov 1, 2020
| updatedRoots = append(updatedRoots, commitment.UpdatedRoot) | ||
| totalTxs += len(commitment.Txs) | ||
|
|
||
| // TODO cleanup |
There was a problem hiding this comment.
Do we want to create an issue that adds an AggregatedSignature wrapper with a method like ToSol()?
| rollupAddress := ethCmn.HexToAddress(config.GlobalCfg.RollupAddress) | ||
| stakeAmount := big.NewInt(0) | ||
|
|
||
| // TODO fix |
There was a problem hiding this comment.
What's the thing we want to fix here? Is it adding a feeReceiver to the config?
There was a problem hiding this comment.
Right now I have added 0 as fee receiver to fix build but we need to replace that with the correct one.
Lets talk here: #47
| return nil | ||
| } | ||
|
|
||
| func (b *Bazooka) GenerateAuthObj(client *ethclient.Client, callMsg ethereum.CallMsg) (auth *bind.TransactOpts, err error) { | ||
| func (b *Bazooka) generateAuthObj(client *ethclient.Client, callMsg ethereum.CallMsg) (auth *bind.TransactOpts, err error) { |
There was a problem hiding this comment.
We change the MixCaps to camelCase here, is the intention that we don't want to export generateAuthObj in the package?
| b.log.Info("Batch prepared", "totalTransactions", totalTxs) | ||
|
|
||
| rollupAddress := ethCmn.HexToAddress(config.GlobalCfg.RollupAddress) | ||
| stakeAmount := big.NewInt(0) |
There was a problem hiding this comment.
We should create an issue to make stakeAmount configurable too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34