Add test interface option #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <select class="option-input" id="option-interface"> | ||
| <option value="object">Object</option> | ||
| <option value="tdd">TDD</option> | ||
| <option value="bdd">BDD</option> |
There was a problem hiding this comment.
Probably want to also add the new qunit interface?
There was a problem hiding this comment.
I considered it, but I haven't actually used it, and I wasn't sure if the this.remote convention worked within the qunit runner. If it operates the same as the others I'll add it to this PR if you'd like.
|
Thanks for the pr. @csnover, I assume there's no technical reason to only support tdd, other than just having the first version have fewer options? |
|
@xdissent I don't see a CLA on file for you ( please see guidelines at https://github.com/theintern/recorder/blob/master/CONTRIBUTING.md#submitting-pull-requests ). |
|
@dylans Just signed CLA (sorry for the weird erroneous comment from my CI server lol) |
jason0x43
force-pushed
the
master
branch
2 times, most recently
from
e11de4a to
6741ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.