Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in AIRR epitope database annotation #258

Open
grst opened this issue Jan 12, 2024 · 0 comments
Open

Mistake in AIRR epitope database annotation #258

grst opened this issue Jan 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@grst
Copy link
Contributor

grst commented Jan 12, 2024

In the chapter it is suggested to convert CDR3 into junction sequences like this:

Warning: many databases follow diverging definition of the CDR3 region. While the cellranger output contains leading ‘C’ and ending ‘F’ and ‘W’, many databases do not. We therefore need to add them to the database entries, in order to obtain correct matches.

cov_abdab["IR_VJ_1_junction_aa"] = "C" + cov_abdab["IR_VJ_1_junction_aa"] + "F"
cov_abdab["IR_VDJ_1_junction_aa"] = "C" + cov_abdab["IR_VDJ_1_junction_aa"] + "W"

However, I don't think this is correct. Both VJ and VDJ sequences can be ending with either F/W depending on the J gene.

Similar problem with IEDB is currently being discussed in scverse/scirpy#469.

ping @drEast .

@grst grst added the bug Something isn't working label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant