feat: check feature compatibility with appnexus flutter (fixes #13) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns for better type safety ✨ feat(BannerViewOptions.kt): add new data class to encapsulate banner view options 🔧 refactor(BannerViewFactory.kt): convert args to BannerViewOptions for better type safety
… ad handling ✨ feat(xandr_android): add AdInitListener and XandrAdListener for better ad event handling 🆕 feat(xandr_android): introduce FlutterState and InterstitialAd models for better state management
…nerViewContainer 🎨 style(xandr_android): improve readability by breaking down complex expressions in XandrAdListener ✨ feat(xandr_android): add support for banner ad resizing based on BannerViewOptions 🔥 remove(xandr_android): remove unused TODO comments in BannerViewOptions
…for better scrolling experience ✨ feat(ad_banner.dart): add new properties to AdBanner for better ad customization 🔧 refactor(BannerViewContainer.kt): use let function for null safety and cleaner code 🔧 refactor(XandrAdListener.kt): fix comment format for better readability 🔧 refactor(BannerViewOptions.kt): remove unnecessary TODO comments after implementation
✨ feat(main.dart): add padding and alignment to text for better readability 🔄 refactor(main.dart): switch adSizes and resize properties for AdBanner instances to improve ad display
…gration for reference 🔧 chore(cspell.json): add 'appnexus' to dictionary to avoid spell check errors
…de.dart' to support asynchronous operations and load mode functionality ✨ feat(main.dart): add ScrollController and StreamController to manage scroll events and check if ad is in viewport 🔧 refactor(main.dart): add listener to _scrollController to add its position to _checkIfAdIsInViewport stream ✨ feat(main.dart): add more Text widgets and a new AdBanner with loadMode set to LoadMode.whenInViewport to demonstrate ad loading when in viewport 🔧 refactor(ad_banner.dart): import 'dart:async' and 'package:xandr/load_mode.dart' to support asynchronous operations and load mode functionality ✨ feat(ad_banner.dart): add loadMode parameter to AdBanner and _HostAdBannerView to determine when the ad is loaded ✨ feat(ad_banner.dart): add loadAd method to trigger ad loading via MethodChannel ✨ feat(ad_banner.dart): add _checkViewport method to check if the ad is in the viewport and load it if it is 🔧 refactor(ad_banner.dart): call loadAd in initState if loadMode is LoadWhenCreated 🔧 refactor(ad_banner.dart): call _checkViewport in initState if loadMode is WhenInViewport 🔧 refactor(ad_banner.dart): add onDoneLoading callback to _HostAdBannerView to update _loading and _loaded states when ad loading is done 🔧 refactor(ad_banner.dart): call loadAd in _HostAdBannerView's onPlatformViewCreated if loadMode is LoadWhenCreated 🔧 refactor(ad_banner.dart): add loadMode to creationParams to pass it to the native code 🔧 refactor(ad_banner.dart): add widgetId to _HostAdBannerView to pass it to the native code 🔧 refactor(ad_banner.dart): complete widgetId in _HostAdBannerView's onPlatformViewCreated if it's not completed yet 🔧 refactor(ad_banner.dart): call onDoneLoading in _HostAdBannerView's onPlatformViewCreated when ad loading is done 🔧 refactor(ad_banner.dart): call loadAd in _HostAdBannerView's onPlatformViewCreated if loadMode is LoadWhenCreated 🔧 refactor(ad_banner.dart): add loadMode to _HostAdBannerView's creationParams to pass it to the native code 🔧 refactor(ad_banner.dart): add loadMode
thekorn
deleted the
13-feat-check-feature-compatibility-with-appnexus-flutter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change