feat: Controller event stream #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 refactor(xandr): replace event delegate with StreamController for better event handling 🎉 feat(xandr): add listen method to XandrController to allow listening to events 🐛 fix(xandr_android): add event triggers to XandrEventHandler methods to emit events when ad is loaded or an error occurs
…AdEvent for better type safety ✨ feat(xandr): add detailed event classes for ad loading events to provide more context about the events 🔧 refactor(xandr): update debugPrint statements to include more detailed event information for better debugging
…etter code organization 🎨 style(main.dart): add more ad sizes to _XandrExampleState for better ad display flexibility 🔧 chore(main.dart): adjust AdBanner parameters for better ad display control 🔨 refactor(ad_banner.dart): convert AdBanner from StatelessWidget to StatefulWidget for dynamic size adjustment ✨ feat(ad_banner.dart): add BannerAdEventDelegate to handle ad events and dynamically adjust ad size 📦 feat(xandr_builder.dart): create new file for XandrBuilder class for better code organization
🔨 build(xandr_android): add ktlint for Kotlin code linting and formatting 📝 docs(CONTRIBUTING.md, cspell.json, melos.yaml): add ktlint to contributing guide, cspell and melos scripts 🎉 feat(.editorconfig): add .editorconfig for Kotlin files to maintain consistent coding styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ad events are now propagated via the controller
Description
Type of Change