Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Standardize customKeywords to support lists #77

Merged

Conversation

thekorn
Copy link
Owner

@thekorn thekorn commented Jun 18, 2024

NOTE: this is a breaking change - custom keyword values are now lists

  • Refactor and standardize the handling of customKeywords across all iOS and Android platforms to support multiple values per key.
  • Align and update custom keyword data types in core interface and related models to improve data handling and flexibility.
  • Simplify and reformat Kotlin constructors and function signatures in Android modules for enhanced readability and consistency.

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

NOTE: this is a breaking change - custom keyword values are now lists
- Refactor and standardize the handling of `customKeywords` across all iOS and Android platforms to support multiple values per key.
- Align and update custom keyword data types in core interface and related models to improve data handling and flexibility.
- Simplify and reformat Kotlin constructors and function signatures in Android modules for enhanced readability and consistency.
@thekorn thekorn linked an issue Jun 18, 2024 that may be closed by this pull request
1 task
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thekorn thekorn merged commit b215139 into main Jun 18, 2024
11 of 14 checks passed
@thekorn thekorn deleted the 76-feat-make-the-custom-keyword-values-a-list-of-string branch June 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: make the custom keyword values a list of string
1 participant