This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
forked from haileys/australia_postcode
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atcruice
force-pushed
the
housekeeping-13443
branch
from
August 21, 2024 08:18
684627c
to
c7ec8b9
Compare
langsharpe
approved these changes
Aug 21, 2024
While the accepted wisdom suggests that Gemfile.lock should be committed for gems, this gem has only development dependencies. It should be useful for GitHub Actions testing to pull in updated gems across the matrix of supported Ruby versions. https://bundler.io/guides/faq.html#using-gemfiles-inside-gems
Resolves deprecation warning. ``` [DEPRECATED] The source :rubygems is deprecated because HTTP requests are insecure. Please change your source to 'https://rubygems.org' if possible, or 'http://rubygems.org' if not. ```
Addresses warning. ``` warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. ```
- smoother CSV handling - avoids unnecessary Postcode instantiation - more explicit Postcode positional instantiation
atcruice
force-pushed
the
housekeeping-13443
branch
from
August 27, 2024 07:13
c7ec8b9
to
fb1ce64
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Post-merge actions
v0.1.5