Fix show-more being displayed over chat messages #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per erming/shout#568: With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages.
Updated the form to not auto complete what we wrote before by removing action="" and adding autocomplete="off" This patch denies erming/shout#518 and removes that. Because without autocomplete, writing suggestions for mobile keyboards was enabled but at the mean time also whenever you clicked on text area to write a new message, you were given a number of your last typed sentences. Especially on mobile, this was a huge buzzkill because after 3-5 sentences on any channel, these suggestions covered your whole screen. So, in order to remove it I did some changes, ensuring writing suggestions still work. I have added autocomplete=off . This commit is related to erming/shout#532
astorije
added
the
Type: Bug
|
Hey @nomadturk, Thanks for this! Also, naive question: what happens if we do not specify any |
You mean |
As per erming/shout#568: With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages.
As per erming/shout#568: With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per erming/shout#568:
With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages.
With this fix Show More button no more will overlap with the underneath text.
As in:
Result will be like:
This fix also includes @xPaw 's contribution as well.
PS: I mistakenly added another commit to this PR and removed it later. See #88 for the next one.