Fix/fetch response error handling #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
from
95ffa3e to
7007003
Compare
|
@rluders Hi |
rluders
requested changes
Oct 10, 2023
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
2 times, most recently
from
17f0db7 to
89e1735
Compare
rluders
force-pushed
the
fix/fetch_response_error_handling
branch
from
89e1735 to
d87bc2e
Compare
|
Looks good @paghar. But the prettier doesn't seem happy. |
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
from
d87bc2e to
3c180e0
Compare
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
from
0a233a5 to
3c180e0
Compare
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
from
e69d2cc to
3c180e0
Compare
|
@rluders Sorry about that. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
- Coverage 99.54% 93.91% -5.64%
==========================================
Files 163 202 +39
Lines 6621 8458 +1837
Branches 401 465 +64
==========================================
+ Hits 6591 7943 +1352
- Misses 30 515 +485
☔ View full report in Codecov by Sentry. |
You need to rebase... If you are having issues with the rebase, I can try to help tomorrow, just let me know if you didn't get into solving the conflict when rebasing. |
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
from
63ec918 to
3c180e0
Compare
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
2 times, most recently
from
58a4c86 to
68a0f4c
Compare
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
from
2eee058 to
a63b068
Compare
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
2 times, most recently
from
68a0f4c to
aee1d35
Compare
paghar
force-pushed
the
fix/fetch_response_error_handling
branch
from
4115473 to
351de7f
Compare
|
@rluders It is fixed now. |
rluders
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
Reference related issues using
#followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.