Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve theme granularity; Full RSC support; Doc example fixes #1104

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Improve theme granularity; Full RSC support; Doc example fixes #1104

merged 8 commits into from
Nov 6, 2023

Conversation

SutuSebastian
Copy link
Collaborator

@SutuSebastian SutuSebastian commented Nov 3, 2023

Changes

  • add granular theme override for: Datepicker, Dropdown, Modal, Navbar, Rating, Sidebar, Table, Timeline, Toast
  • fixed TableBody theme prop to receive FlowbiteTableBodyTheme instead of FlowbiteTableCellTheme

Extras

API changes

  • Navbar theme object contains all styles for all Navbar sub-components (like it should've from the beginning)
  • Sidebar theme object items and itemsGroup are now objects and have base (eg: items: { base: '...' }) instead of plain string
  • Timeline theme object theme.item.content.[body, time, title] are now objects with { base: '...' } instead of plain string

- remove redundant `PropsWithChildren`
- add granular theme override for: Datepicker, Dropdown, Modal, Navbar, Rating, Sidebar, Table, Timeline, Toast
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 10:36am

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7461173) 99.54% compared to head (1a8745f) 98.71%.
Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
- Coverage   99.54%   98.71%   -0.83%     
==========================================
  Files         163      173      +10     
  Lines        6621     7966    +1345     
  Branches      401      474      +73     
==========================================
+ Hits         6591     7864    +1273     
- Misses         30      102      +72     

see 149 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…me object to `TableHeadCell` and `TableCell`
@SutuSebastian SutuSebastian changed the title Theme Improve theme granularity Nov 5, 2023
- `TimelineItem` -> [`TimelinePoint`, `TimelineContent`]
- `TimelineContent` ->  [`TimelineTime`, `TimelineTitle`, `TimelineBody`]
@SutuSebastian SutuSebastian changed the title Improve theme granularity Improve theme granularity + Full RSC support Nov 6, 2023
@SutuSebastian SutuSebastian changed the title Improve theme granularity + Full RSC support Improve theme granularity; Full RSC support; Doc example fixes Nov 6, 2023
@rluders rluders merged commit 5bea210 into themesberg:main Nov 6, 2023
4 checks passed
@SutuSebastian SutuSebastian deleted the components/granular-theming branch November 6, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants