-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve theme granularity; Full RSC support; Doc example fixes #1104
Merged
rluders
merged 8 commits into
themesberg:main
from
SutuSebastian:components/granular-theming
Nov 6, 2023
Merged
Improve theme granularity; Full RSC support; Doc example fixes #1104
rluders
merged 8 commits into
themesberg:main
from
SutuSebastian:components/granular-theming
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 99.54% 98.71% -0.83%
==========================================
Files 163 173 +10
Lines 6621 7966 +1345
Branches 401 474 +73
==========================================
+ Hits 6591 7864 +1273
- Misses 30 102 +72 ☔ View full report in Codecov by Sentry. |
…me object to `TableHeadCell` and `TableCell`
- `TimelineItem` -> [`TimelinePoint`, `TimelineContent`] - `TimelineContent` -> [`TimelineTime`, `TimelineTitle`, `TimelineBody`]
SutuSebastian
changed the title
Improve theme granularity
Improve theme granularity + Full RSC support
Nov 6, 2023
SutuSebastian
changed the title
Improve theme granularity + Full RSC support
Improve theme granularity; Full RSC support; Doc example fixes
Nov 6, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Datepicker
,Dropdown
,Modal
,Navbar
,Rating
,Sidebar
,Table
,Timeline
,Toast
TableBody
theme
prop to receiveFlowbiteTableBodyTheme
instead ofFlowbiteTableCellTheme
Extras
PropsWithChildren
avatar.stackedLayout.tsx
code examplerating.advanced.tsx
code exampleAPI changes
Navbar
theme object contains all styles for all Navbar sub-components (like it should've from the beginning)Sidebar
theme objectitems
anditemsGroup
are now objects and havebase
(eg: items:{ base: '...' }
) instead of plain stringTimeline
theme objecttheme.item.content.[body, time, title]
are now objects with{ base: '...' }
instead of plain string