Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classes/Options_V2: Update the permalink when changing the course slug #564

Closed
wants to merge 1 commit into from

Conversation

bernhardkaindl
Copy link

Also, fold a variable that was only used once.

This is @shewa12's #549, rebased (with conflicts resolved) to the current dev branch.

Also, fold a variable that was only used once.

Co-authored-by: Bernhard Kaindl <[email protected]>
@shewa12
Copy link
Collaborator

shewa12 commented Sep 28, 2023

This feature is already released

@bernhardkaindl
Copy link
Author

bernhardkaindl commented Oct 15, 2023

This feature is already released

@sazedul-haque, or someone else, please have a look at this:

Yes, but not working for existing courses!!!!!!!!!!!!!!!! See bug #576!!!

Renaming the course base slug of existing courses is missing. They stay with their old slug!!!

These changes (of this Pull Request) which @shewa12 made, may do that, right?

These changes have not been merged yet!!!

	array(
		'key'         => 'course_permalink_base',
		'type'        => 'text',
		'label'       => __( 'Course Slug', 'tutor' ),
		'placeholder' => __( 'Course Slug', 'tutor' ),
		'label_title' => '',
		'default'     => tutor()->course_post_type,
		'desc'        => __( 'Update the permalink when changing the course slug', 'tutor' ),
	),

The same renaming would also have to be done when the lesson base slug changes, which is also not done.

@shewa12 shewa12 closed this Aug 7, 2024
@bernhardkaindl
Copy link
Author

@shewa12 I guess handling changes to the course and lesson base slugs may have been fixed meanwhile, but it would be great if you could communicate about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants