Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the autocomplete filter #210

Closed
wants to merge 1 commit into from

Conversation

link2qaiser
Copy link

#192 Username autocomplete endpoint
Add the DRF filter for Search critaria

Copy link
Contributor

@MAbdurrehman1 MAbdurrehman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should make a separate file/view for this. I think, we can reuse the existing viewset, and introduce some generic searching to it.

ps: Instead of specific user search with username only, can we have a generic search?
Where I can have a list of search_fields and the searching can be done according to those.

EXACTLY how Django does it in the admin side:
image
image

and all the searching is being controlled by just this search_fields configuration:
image

Note: I think we are already using django_filters so it can be re-used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants