Add final page fail #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for a11yinyerface ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fsoussand
force-pushed
the
add-final-page-fail
branch
7 times, most recently
from
c119480 to
c44434c
Compare
This was referenced Jul 3, 2023
Open
|
Sur la page oeufs on ne devrait pas avoir les noms des ingrédients ? |
RobinCar
reviewed
Jul 4, 2023
src/pages/final.tsx
Outdated
|
|
||
| const isCartValid = missingCartTitles.length == 0; | ||
|
|
||
| const textSuccess = ( |
There was a problem hiding this comment.
C'est bizarre de l'appeler textSuccess alors que c'est tout un composanst avec un logo aussi non ? On peut peut-être l'exporter dans un composant SuccessComponent, t'en pense quoi ?
src/pages/final.tsx
Outdated
| </Container> | ||
| ); | ||
|
|
||
| const textFailure = ( |
fsoussand
force-pushed
the
add-final-page-fail
branch
3 times, most recently
from
38812a4 to
ff9196e
Compare
fsoussand
force-pushed
the
add-final-page-fail
branch
from
2affabc to
e3a81bf
Compare
RobinCar
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request doing ?
This PR regroups the creation of the egg page and the final page in case of failure
#41
#50
#62
Screenshot
How is it done ?
How to test ?
Go to https://deploy-preview-73--a11yinyerface.netlify.app/egg and add one egg to your cart
Go to https://deploy-preview-73--a11yinyerface.netlify.app/final : you should see the failure page indicating you that you have no flour or apple
Go to https://deploy-preview-73--a11yinyerface.netlify.app/fruits and to https://deploy-preview-73--a11yinyerface.netlify.app/flour, add the right ingredients and then check that the final page is the success one