-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Dimension #650
base: main
Are you sure you want to change the base?
Delete Dimension #650
Conversation
nice! Thanks :D To make the DX slightly easier, I think I might
It's all fairly subjective, but it's sort of the fun part in trying to design a more intuitive interface for users than google's apis, which is what this module is all about. Also we'll need to add tests and docs before merging. Cheers and thanks! |
Can you please merge this asap? I need to use it in my package for a project. This would help, Thanks! |
Agree, could this be merged please? |
This will work great in my project! Could this be merged please? |
Could definitely use this on a project I'm working on, is there any way we could get this merged soon? |
cf803e0
to
53fe384
Compare
Could use this as well! |
@theoephraim It looks like some changes you suggested still need to be done... should I fork @ahmedrizwan239 fork or make my own? |
@ururk - yeah if you're up for it, got for it! The functionality itself is pretty simple, but need to add tests, docs, and ideally make the DX a little simpler... Otherwise I'll try to get to it asap |
I'm taking stab at it, hopefully have something for today. I have the two additional methods written and was looking at your tests |
Implementation of the deleteDimension api call.