This repository has been archived by the owner on Feb 13, 2019. It is now read-only.
Creative size #311
Open
Creative size #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spra85
reviewed
Jun 6, 2017
| @@ -55,6 +55,9 @@ export default class Revealed extends React.Component { | |||
| let specialCoverage = this.props.targetSpecialCoverage || 'None'; | |||
| let autoplayInViewBool = typeof this.props.autoplayInView === 'string'; | |||
|
|
|||
| // Allowing creativeSize to be passed in in root.js | |||
| let creativeSize = this.props.creativeSize; | |||
There was a problem hiding this comment.
I would make this an optional attribute, with a default value of 640x480, so simply change this to:
let creativeSize = this.props.creativeSize || '640x480';
spra85
reviewed
Jun 6, 2017
| @@ -60,6 +60,7 @@ Object.assign(RailPlayer, { | |||
| }, | |||
| propTypes: { | |||
| channel: PropTypes.string.isRequired, | |||
| creativeSize: PropTypes.string, | |||
There was a problem hiding this comment.
I don't think you actually need the creativeSize propType defined here.
There was a problem hiding this comment.
true statement, still works without it
spra85
reviewed
Jun 6, 2017
| @@ -171,7 +176,7 @@ export default class Revealed extends React.Component { | |||
| let type; | |||
|
|
|||
| // See docs (https://support.google.com/dfp_premium/answer/1068325?hl=en) for param info | |||
| baseUrl += '?sz=640x480'; | |||
| baseUrl += `?sz=${this.props.creativeSize}`; | |||
There was a problem hiding this comment.
So, you should either find a way to use the creativeSize you defined above in the let assignment or do what you're doing here but otherwise the assignment above isn't used.
There was a problem hiding this comment.
so if I removed the PropTypes line, does that mean this gets to stay?
…idden from the default of 640x480
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add ability to pass in a VAST video size for the rail unit rather than have it hardcoded
Ticket
https://app.asana.com/0/342156387987716/354541582224232
@spra85 I'm not sure how to do like a test link, but I was testing it in the bulbs local webpack on the rail-player with campaign and it is working there..
Also not sure how the tests work yet, but figured I'd put this up here for now!