Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Universal toggle button #4115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: Universal toggle button #4115

wants to merge 3 commits into from

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Jan 7, 2025 •
edited
Loading

What does this PR do?

  • Simplifies toggle button setup so that styles are defined once in a shared component ToggleIconButton.tsx
  • Adds a custom "strikethrough" icon overlay to remove reliance on active/inactive icon pairings when using toggle buttons

Test:
https://4115.planx.pizza/barnet/find-out-if-you-need-planning-permission

Before change:
image

After change (small visual difference):
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Pizza

Deployed ba15b55 to https://4115.planx.pizza.

Useful links:

@ianjon3s ianjon3s changed the title refactor: Universal toggle icon refactor: Universal toggle button Jan 8, 2025
@ianjon3s ianjon3s marked this pull request as ready for review January 8, 2025 09:29
@ianjon3s ianjon3s requested a review from a team January 8, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ianjon3s