Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partition checking #160

Closed
wants to merge 1 commit into from
Closed

Fix partition checking #160

wants to merge 1 commit into from

Conversation

marco44
Copy link
Contributor

@marco44 marco44 commented Mar 23, 2018

Now return string of partitions_are are sorted with a reproducible order
(collate C)

This should fix build error seen in #153 , which seems to be a coincidence

@marco44 marco44 force-pushed the fix_partition_tests branch from efac8f3 to 157128a Compare March 23, 2018 10:37
Fix partition checking
3f82835 
Now return string of partitions_are are sorted with a reproducible order
(collate C)
@marco44 marco44 force-pushed the fix_partition_tests branch from 157128a to 3f82835 Compare March 23, 2018 10:53
@theory
Copy link
Owner

theory commented Mar 23, 2018

I have the same basic objections to this patch as to #159.

@marco44
Copy link
Contributor Author

marco44 commented Mar 23, 2018

Well you can drop this one then :)

This was just to try to have #153 pass CI... I can rebase #153 back on master

@theory theory closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marco44 @theory