Adds Immich API authentication method #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theothernt
reviewed
Oct 7, 2024
| } | ||
|
|
||
| private fun getApiInterface() { | ||
| val trustAllCerts = arrayOf<TrustManager>(object : X509TrustManager { |
There was a problem hiding this comment.
Is those code needed to ignore invalid or local SSL certs?
There was a problem hiding this comment.
Yes, if there is a better method I think it should be utilized instead. Without this code I was getting the following error:
javax.net.ssl.SSLHandshakeException: Chain validation failed Caused by: java.security.cert.CertificateException: Chain validation failed
…PI error messages when selecting album
… API with test connection settings button
…elf-signed certificates
…elf-signed certificates
Just moved a few things around after the merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds API authentication as discussed in #163 and attempted to follow and expand on similar methods as implemented in #164
This implementation supports both shared links and an API access code, to allow the user to easily select their prefered method of adding Immich to the app. There are still errors displaying videos when the API access is used and should be fixed before merging into main, I am just opening this incase others wanted to help.
Screenshots for Shared Link
Screenshots for API
Select Album options on API link
