Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed param typo #418

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fixed param typo #418

merged 2 commits into from
Dec 20, 2024

Conversation

deluxetom
Copy link

@deluxetom deluxetom commented Dec 20, 2024

Had a typo for an API param

I wonder if we should throw an exception when a manipulator gets a param that's not allowed?

@ADmad ADmad merged commit d6539da into thephpleague:3.x Dec 20, 2024
7 checks passed
@ADmad ADmad added this to the 3.x milestone Dec 20, 2024
@ADmad
Copy link
Collaborator

ADmad commented Dec 20, 2024

I wonder if we should throw an exception when a manipulator gets a param that's not allowed?

Well Api::run() calls that the setParams() of each manipulator before running it. If we were to add an exception we would have to first get the valid params list of each manipulator and filter out the "invalid" ones. I don't think there's anything to be gained by doing that, it would just add CPU cycles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants