Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Twitter urlAuthorization to 'authorize' #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch Twitter urlAuthorization to 'authorize' #87

wants to merge 1 commit into from

Conversation

ttomdewit
Copy link

When working with Socialite I noticed the callback URL for Twitter was wrong, at least for me. This PR aims to fix that.

I read your contributing guide but failed to find any existing tests to test Twitter. I'd be more than happy to work with you to make this a useful contribution and I thank you for your time and effort.

@bencorlett
Copy link
Member

@ttomdewit apologies for how stale this PR is. The project has been in hiatus for a few years now but we're working on a rewrite.

The /oauth/authorize endpoint aims to be an alternative to the /oauth/authenticate endpoint - both are used for retrieving a verifier token which can be in turn used for retrieving token credentials.

I think we could look to possibly support both endpoints within the Twitter provider based on configuration. I'll look at doing that in #111 and close this PR once that's been implemented.

@Diegslapasteque
Copy link

Hello @bencorlett,
We're using laravel/socialite too, and since a few days, we have an issue on the /oauth/authenticate endpoint (infinite loop during oauth process).
Other users have the issue too, and switching to the /oauth/authorize endpoint fix the issue.

Here is the bug ticket on Twitter : https://twittercommunity.com/t/infinite-redirect-loop-during-oauth-process/184086

Is it possible to take a look?
Thank you.

@cmoreau
Copy link

cmoreau commented Feb 1, 2023

Ooooh thank you so much @Diegslapasteque ! We are experiencing the same issue since few days and just notice this workaround. Hope the team will quickly validate your PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants