Decouple error responses from exception #1113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 20, 2020 21:27
…ponse from an OAuthServerException
…actors lib accordingly
|
I find this idea an awesome one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the generation of the error responses from the OAuthServerException by moving the function to a new
ExceptionResponseHandlerInterfacewith a defaultExceptionResponseHandlerimplementation.The handler gets injected into the authorization and resource server and is used via a
::generateHttpResponeproxy method.This way required changes are minized while the libraries error responses can be easily overridden or adapted. This change is motivated by adding support for translated error response payloads in a second step.
Relates to #972, #884, #747