getting_started: intel_debug: Update the sof-dyndbg.conf example #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
requested review from
lgirdwood,
deb-intel,
intelkevinputnam,
mmaka1 and
mwasko
as code owners
lgirdwood
reviewed
Dec 21, 2023
| options snd_sof_intel_hda_common dyndbg=+pmf | ||
| options snd_sof_intel_hda_generic dyndbg=+pmf |
There was a problem hiding this comment.
Should we say from whence ? i.e. from 6.6+ do this else do that.
There was a problem hiding this comment.
I will separate the two change.
I cannot find any indication that we ever had snd_sof_intel_ipc
ujfalusi
force-pushed
the
pr/dyndbg_update_02
branch
from
9331564
to
7eaa784
Compare
There were never a module named snd_sof_intel_ipc, at least I cannot find it in kernel history. Signed-off-by: Peter Ujfalusi <[email protected]>
Add snd_sof_intel_hda_generic to the list of modules. Signed-off-by: Peter Ujfalusi <[email protected]>
|
Changes since v1:
|
plbossart
approved these changes
Jan 3, 2024
lgirdwood
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snd_sof_intel_hda_generic and remove snd_sof_intel_ipc to the list