Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intel_debug: introduction: Update the note for Meteor Lake topology path #483

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

ujfalusi
Copy link
Contributor

Restrict the sof-ace-tplg symlink need to Meteor Lake only and change the sentecne as suggested by @deb-intel

Replaces #482

Restrict the sof-ace-tplg symlink need to Meteor Lake only and change the
sentecne as suggested by @deb-intel

Signed-off-by: Peter Ujfalusi <[email protected]>
@@ -182,7 +182,7 @@ reconfigured with tools but requires expert knowledge of the ALSA/ASoC/topology
- CONFIG = topology variant needed for detected hardware configuration

Important notices:
- For compatibility reasons for **Meteor Lake and newer** ``/lib/firmware/intel/sof-ace-tplg`` must be symlinked to ``/lib/firmware/intel/sof-ipc4-tplg``
- For compatibility reasons with respect to **Meteor Lake** ``/lib/firmware/intel/sof-ace-tplg`` must be symlinked to ``/lib/firmware/intel/sof-ipc4-tplg``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that change is only true if there is a kernel change to change the default path for LNL and directly use sof-ipc4-tplg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I can convert this to draft for now until we have consensus on it?
Since LNL is not released I would try to align with this change, just to make our legacy shorter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant is that IF you want this change for LNL you need to send a kernel PR... I don't personally feel it's necessary but I am not going to lay on the tracks for a path replacement.

And once all the topology and kernel patches are merged we can merge this document and publish it.

@ujfalusi ujfalusi marked this pull request as draft January 10, 2024 13:46
@ujfalusi
Copy link
Contributor Author

ujfalusi commented Jan 15, 2024

PR needed to be merged prior to this update:

@ujfalusi ujfalusi marked this pull request as ready for review January 15, 2024 11:24
@ujfalusi
Copy link
Contributor Author

@plbossart, @lgirdwood, @kv2019i, the firmware topology build change is merged now and also the kernel side LNL path change.
I think the update in this PR is now appropriate.

@deb-intel
Copy link
Collaborator

@plbossart, @lgirdwood, @kv2019i, the firmware topology build change is merged now and also the kernel side LNL path change. I think the update in this PR is now appropriate.

I will publish the website when this is merged.

@lgirdwood lgirdwood merged commit eba3634 into thesofproject:master Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants