Add 2024-01-01 and 2025-01-01 Regulations to History #10480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nanush7
changed the title
gregorbg
requested changes
Jan 3, 2025
| <li><%= link_to "2025-01-01", "./official/2025-01-01/" %> (<%= link_to "Changes", "https://github.com/thewca/wca-regulations/compare/official-2024-01-01...official-2025-01-01-fixed#files_bucket" %>, <%= link_to "Summarized Changes", "https://www.worldcubeassociation.org/posts/wca-regulations-january-2025" %>)</li> | ||
| <li><%= link_to "2024-01-01", "./official/2024-01-01/" %> (<%= link_to "Changes", "https://github.com/thewca/wca-regulations/compare/official-2023-08-01...official-2024-01-01#files_bucket" %>, <%= link_to "Summarized Changes", "https://www.worldcubeassociation.org/posts/wca-regulations-january-2024" %>)</li> | ||
| <li><%= link_to "2023-08-01", "./official/2023-08-01/" %> (<%= link_to "Changes", "https://github.com/thewca/wca-regulations/compare/official-2023-02-01...official-2023-08-01#files_bucket" %>, <%= link_to "Summarized Changes", "https://www.worldcubeassociation.org/posts/wca-regulations-august-2023" %>) | ||
| <ul> |
There was a problem hiding this comment.
Why are you opening a new ul here?
There was a problem hiding this comment.
Versions of the same year should be displayed in a nested list (for some reason I'm unaware of). See here.
gregorbg
approved these changes
Jan 4, 2025
|
LGTM, can this be merged now? (Seeing that 2025-01-01 regs are released) |
|
Yes! (and please see the latest WRC-WST email). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Do not merge before 2024-01-01 Regulations and Guidelines are released !!!
@thewca/wrc-team please review in case there's something wrong. It's a simple change, but I couldn't test it because docker-compose is not working for me.
We may need to wait for thewca/wca-regulations#1191 as well.