BUG: Fix 32-bit truncation on VectorImage Accessors

Initial bug reported in SimpleITK/SimpleITK#2220. On 64-bit windows system, truncation to 32-bit (unsigned long) was occouring when setting VectorImages with over 4GB buffers.
thewtex · Dec 15, 2024 · ee63f5e · ee63f5e
1 parent 9d4f1ab
commit ee63f5e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Modules/Core/Common/include/itkDefaultVectorPixelAccessor.h b/Modules/Core/Common/include/itkDefaultVectorPixelAccessor.h
@@ -63,7 +63,7 @@ class ITK_TEMPLATE_EXPORT DefaultVectorPixelAccessor
 
   /** Set output using the value in input */
   inline void
-  Set(InternalType & output, const ExternalType & input, const unsigned long offset) const
+  Set(InternalType & output, const ExternalType & input, const SizeValueType offset) const
   {
     InternalType * truePixel = (&output) + offset * m_OffsetMultiplier;
 

diff --git a/Modules/Core/ImageAdaptors/include/itkNthElementPixelAccessor.h b/Modules/Core/ImageAdaptors/include/itkNthElementPixelAccessor.h
@@ -144,7 +144,7 @@ class NthElementPixelAccessor<TOutputPixelType, itk::VariableLengthVector<TPixel
   }
 
   inline void
-  Set(InternalType & output, const ExternalType & input, const unsigned long offset) const
+  Set(InternalType & output, const ExternalType & input, const SizeValueType offset) const
   {
     // note: v is a reference to the internal buffer, this method of
     // access relies on return value optimization to work

diff --git a/Modules/Core/ImageAdaptors/include/itkVectorImageToImageAdaptor.h b/Modules/Core/ImageAdaptors/include/itkVectorImageToImageAdaptor.h
@@ -66,7 +66,7 @@ class VectorImageToImagePixelAccessor : private DefaultVectorPixelAccessor<TType
   }
 
   inline void
-  Set(InternalType & output, const ExternalType & input, const unsigned long offset) const
+  Set(InternalType & output, const ExternalType & input, const SizeValueType offset) const
   {
     return Set(Superclass::Get(output, offset), input);
   }